-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update NPM packages & start to use Node 20 #38
Update NPM packages & start to use Node 20 #38
Conversation
lb-
commented
Nov 12, 2023
- Update all packages to the latest available
- Changed: replaced deprecated scss/at-import-no-partial-leading-underscore rule with scss/load-no-partial-leading-underscore rule.
- Update Node to use version 20 (including CI).
- Wagtail core is now on Node 20, so hoping to align Upgrade to Node 20 wagtail#11141
- Changed: replaced deprecated scss/at-import-no-partial-leading-underscore rule with scss/load-no-partial-leading-underscore rule. - Update Node to use version 20 (including CI) - Update all packages to the latest available
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment but otherwise this looks good to me!
| [`scss/dollar-variable-no-missing-interpolation`][44] | Enabled | | ||
| [`scss/function-quote-no-quoted-strings-inside`][45] | Enabled | | ||
| [`scss/function-unquote-no-unquoted-strings-inside`][46] | Enabled | | ||
| [`scss/load-no-partial-leading-underscore`][47] | Enabled | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would produce a much smaller diff if we just update scss/at-import-no-partial-leading-underscore
with scss/load-no-partial-leading-underscore
instead of removing the former and appending the latter to the bottom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This listing is generated automatically. It would probably be a lot more work to make it ordered custom.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #27 for context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I didn't know that. That's cool, thanks!
[44]: https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/dollar-variable-no-missing-interpolation/README.md | ||
[45]: https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/function-quote-no-quoted-strings-inside/README.md | ||
[46]: https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/function-unquote-no-unquoted-strings-inside/README.md | ||
[47]: https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/load-no-partial-leading-underscore/README.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above